9 Feb
2020
9 Feb
'20
3:59 a.m.
On Sun, Feb 9, 2020 at 8:38 AM Heinrich Schuchardt xypron.glpk@gmx.de wrote:
The network connection speed is a debug information. So we should use debug() and not printf().
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
drivers/net/designware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/designware.c b/drivers/net/designware.c index 19fc34f771..a89f4bedf1 100644 --- a/drivers/net/designware.c +++ b/drivers/net/designware.c @@ -255,9 +255,9 @@ static int dw_adjust_link(struct dw_eth_dev *priv, struct eth_mac_regs *mac_p,
writel(conf, &mac_p->conf);
printf("Speed: %d, %s duplex%s\n", phydev->speed,(phydev->duplex) ? "full" : "half",(phydev->port == PORT_FIBRE) ? ", fiber mode" : "");
debug("Speed: %d, %s duplex%s\n", phydev->speed,(phydev->duplex) ? "full" : "half",(phydev->port == PORT_FIBRE) ? ", fiber mode" : "");
Maybe this was intentional as I see such in the MACB driver as well. Leaving this to Joe and original author of this driver to comment.
Regards, Bin