Dear Kevin,
in message 4B2796B7.3000300@fearnside-systems.co.uk you wrote:
All I really wanted to do was change the sc324x0 register struct members to lower case, but if I do that without cleaning up the white space I get checkpatch.pl errors, and if I don't change the code to use the accessor functions the patch will get NAK-ed anyway...and all I really want to do is get the code into a state where I can add support for the Embest SBC244-II Board!
I understand and appreciate your efforts.
In such a situation it is actually not really important in which order the changes are performend, but they shouldbe separated into orthogonal patches, and these patches submitted as a series.
I think I'll split the patches into a white-space change followed by an accessor function/s3c24x0 register change patch.
This is indeed the optimal sequence in this situation.
Please also re-check the resulting code. I think there are some way too long lines, etc.
checkpatch.pl didn't report any line length errors before I emailed the patches. I'll check it again.
Thanks.
Best regards,
Wolfgang Denk