Re: [U-Boot] [PATCH v3 1/5] dm: clk: add stub for clk_disable_bulk when CONFIG_CLK is desactivated

Hi Patrick,

On 12/11/2019 10:42, Patrick Delaunay wrote:

Add stub for clk_disable_bulk() when CONFIG_CLK is desactivated.

That avoid compilation issue (undefined reference to `clk_disable_bulk') for code:

clk_disable_bulk(&priv->clks); clk_release_bulk(&priv->clks);

Signed-off-by: Patrick Delaunay patrick.delaunay@st.com

Changes in v3:

• Add stub for clk_disable_bulk

Changes in v2: None

include/clk.h | 4 ++++ 1 file changed, 4 insertions(+)

diff --git a/include/clk.h b/include/clk.h index a5ee53d94a..6f0b0fe4bc 100644 --- a/include/clk.h +++ b/include/clk.h @@ -379,7 +379,11 @@ int clk_disable(struct clk *clk);

• by clk_get_bulk().
  

• @return zero on success, or -ve error code.

*/

• #if CONFIG_IS_ENABLED(CLK) int clk_disable_bulk(struct clk_bulk *bulk);

+#else +inline int clk_disable_bulk(struct clk_bulk *bulk) { return 0; } +#endif

Maybe this could be done for all clk operations ?

JJ

/**

• clk_is_match - check if two clk's point to the same hardware clock