On 03.08.21 16:28, Pali Rohár wrote:
Show "## Start Addr" or "## Binary (...) download aborted" information like in Kermit "loadb" command.
Signed-off-by: Pali Rohár pali@kernel.org
cmd/load.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/cmd/load.c b/cmd/load.c index 1ed05a9cd21e..573c44b912fd 100644 --- a/cmd/load.c +++ b/cmd/load.c @@ -474,6 +474,14 @@ static int do_load_serial_bin(struct cmd_tbl *cmdtp, int flag, int argc,
addr = load_serial_ymodem(offset, xyzModem_ymodem);
if (addr == ~0) {image_load_addr = 0;printf("## Binary (ymodem) download aborted\n");
xyzModem_stream_terminate() already prints a message "!!!! TRANSFER ABORT !!!!\n" if the transfer is aborted.
rcode = 1;} else {printf("## Start Addr = 0x%08lX\n", addr);
In existing code '## ' is used to indicate errors. This message is not for an error.
Please, avoid alternative language referring to the load address. Cf. net/nfs.c:918: printf("\nLoad address: 0x%lx\nLoading: *\b", image_load_addr); net/tftp.c:851: printf("Load address: 0x%lx\n", tftp_load_addr); net/tftp.c:905: printf("Load address: 0x%lx\n", tftp_load_addr)
Please, use log_err() and log_info() instead of printf().
Best regards
Heinrich
image_load_addr = addr;}@@ -482,6 +490,14 @@ static int do_load_serial_bin(struct cmd_tbl *cmdtp, int flag, int argc,
addr = load_serial_ymodem(offset, xyzModem_xmodem);
if (addr == ~0) {image_load_addr = 0;printf("## Binary (xmodem) download aborted\n");rcode = 1;} else {printf("## Start Addr = 0x%08lX\n", addr);image_load_addr = addr;}} else {
printf("## Ready for binary (kermit) download "