-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Monday, August 10, 2009 2:00 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] [PATCH 6/8] tools: mkimage: Making table_entry code global
Dear Prafulla Wadaskar,
In message <73173D32E9439E4ABB5151606C3E19E202E121613D@SC-VEXCH1.marvell. com> you wrote:
I have gone through all the feedback that you have provided
for this entire patch series.
Thanks a lot...
Thank you for your pat6ience. Sorry it's such a long story for such a apparently small addition.
That's what my earlier intention was:-) Just to add small support with minimal modifications. But while doing it, the idea has generated why not improve it further? Like header_size, function callbacks. That need more work/rework and I can understand there will be more spins to get it through. So here I am to support you :-D
I tried to maintain the flow in the series for easy
understanding, but I failed :-(
Actually you did not. I just did not agree with some implementation details. And the changes need beter documentation.
Yes, I will take care of documentation, thanks
With these patches, new code looks differently compared to
original code.
So I feel instead of providing incremental patches- I should provide
- basic mkimge framework patch,
- mkimage: add: uimage support patch,
- mkimage: add: fit image support patch,
Um... these three must never be split. I mean, we should not add any patch that breaks the (existing) mkimage support.
Okay I will take care of this
- mkimage: add: Kirkwood boot image support patch.
I will do this in my next post. I hope you will like it. If you have any inputs in this regard or you think this is
bad plan, pls kindly let me know.
I'm not sure if this will be an improvement. I guess it will make it even harder to understand the changes.
Then I will try to post patches better combination of incremental ones :-)
Thanks and regards.. Prafulla . .
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "Infidels in all ages have battled for the rights of man, and have at all times been the fearless advocates of liberty and justice."
- Robert Green Ingersoll