On Sun, 20 Jun 2010 21:32:48 +0400 Ilya Yanok yanok@emcraft.com wrote:
This patch provides support for MPC8308ERDB development board from Freescale with a minimal set of features: Dual UART is supported NOR flash is supported Both TSEC Ethernet controllers are supported PCI Express initialization is supported
The following features are enabled in configuration but not fully tested: I2C (used to get the board revision) I2C-connected RTC VSC7385 switch
Signed-off-by: Ilya Yanok yanok@emcraft.com
thanks for submitting this, Ilya.
The comments below are in addition to Wolfgang's.
MAKEALL | 1 + Makefile | 3 + board/freescale/mpc8308erdb/Makefile | 52 +++ board/freescale/mpc8308erdb/config.mk | 1 + board/freescale/mpc8308erdb/mpc8308erdb.c | 154 ++++++++ board/freescale/mpc8308erdb/sdram.c | 126 +++++++ include/configs/MPC8308ERDB.h | 572 +++++++++++++++++++++++++++++ 7 files changed, 909 insertions(+), 0 deletions(-) create mode 100644 board/freescale/mpc8308erdb/Makefile create mode 100644 board/freescale/mpc8308erdb/config.mk create mode 100644 board/freescale/mpc8308erdb/mpc8308erdb.c create mode 100644 board/freescale/mpc8308erdb/sdram.c create mode 100644 include/configs/MPC8308ERDB.h
missing a doc/README.mpc8308erdb file.
+MPC8308ERDB_config: unconfig
- @$(MKCONFIG) -a MPC8308ERDB powerpc mpc83xx mpc8308erdb freescale
patch doesn't apply to WD's next branch:
--- Applying: MPC8308ERDB: minimal support for devboard from Freescale error: patch failed: Makefile:2233 error: Makefile: patch does not apply /home/r1aaha/git/u-boot/.git/rebase-apply/patch:112: new blank line at EOF. + Patch failed at 0002 MPC8308ERDB: minimal support for devboard from Freescale When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". ---
please rebase on top of Wolfgang's next branch, and also fix the new blank line at EOF.
+#define CONFIG_MPC831x 1 /* MPC831x CPU family */
I don't see the 8308 being a member of the 831x family; e.g., upper spridr bits are 0x810, which don't match those of 831x: 0x80B. Please introduce a new CONFIG_MPC830x.
+/*
- There are neither HRCWH_PCI_HOST nor HRCWH_PCI1_ARBITER_ENABLE bits
- in 8308's HRCWH according to the manual, but original Freescale's
- code has them and I've expirienced some problems using the board
- with BDI3000 attached when I've tried to set these bits to zero
- (UART doesn't work after the 'reset run' command).
is the BDI overriding the RCW in this case? it's not clear..
+#define CFG_SICRH 0x01001003 +#define CFG_SICRL 0x00000040 /* 3.3V, no delay */
the CFG_ prefix is no longer - are these even being used anywhere?
+#define CONFIG_SYS_HID0_FINAL (HID0_ENABLE_MACHINE_CHECK | \
HID0_ENABLE_DYNAMIC_POWER_MANAGMENT)
| HID0_ENABLE_INSTRUCTION_CACHE?
Thanks,
Kim