On Sat, 2016-07-30 at 14:43 +0200, Hans de Goede wrote:
It seems that bytes 13-14 of the SID / bytes 1-2 from word 3 of the SID are always 0 on H3 making it a poor candidate to use as source for the serialnr / mac-address, and the other non constant words (1 and 2) also have quite a few bits which are the same for some boards,
This commits switches to using the crc32 of words 1 - 3 to get a more unique value for the mac-address / serialnr.
Cc: Chen-Yu Tsai wens@csie.org Cc: Corentin LABBE clabbe.montjoie@gmail.com Cc: Amit Singh Tomar amittomer25@gmail.com Signed-off-by: Hans de Goede hdegoede@redhat.com
Acked-by: Ian Campbell ijc@hellion.org.uk
Two minor thoughts:
At some point it might be nice to switch from using sid[3] as the temporary variable to contain the csum since it is no longer the 3rd element of the sid in any meaningful way. If you decide to do so for a v4, then please do keep my ack from above.
Likewise if you decide to express the big chain of ifndef's via Kconfig instead, you can keep the ack.
Ian.