Re: [U-Boot] [PATCH] spi: xilinx: Read reg base address from DTS file

On 26 July 2016 at 10:48, Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com wrote:

From: Michal Simek michal.simek@xilinx.com

Do not use DM with reg base hardcoding.

Signed-off-by: Michal Simek michal.simek@xilinx.com

drivers/spi/xilinx_spi.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c index 3e01c66..c557529 100644 --- a/drivers/spi/xilinx_spi.c +++ b/drivers/spi/xilinx_spi.c @@ -80,10 +80,6 @@ DECLARE_GLOBAL_DATA_PTR; #define CONFIG_XILINX_SPI_IDLE_VAL GENMASK(7, 0) #endif

-#ifndef CONFIG_SYS_XILINX_SPI_LIST -#define CONFIG_SYS_XILINX_SPI_LIST { CONFIG_SYS_SPI_BASE } -#endif

#define XILINX_SPI_QUAD_MODE 2

/* xilinx spi register set */ @@ -112,8 +108,6 @@ struct xilinx_spi_priv { unsigned int mode; };

-static unsigned long xilinx_spi_base_list[] = CONFIG_SYS_XILINX_SPI_LIST;

static int xilinx_spi_child_pre_probe(struct udevice *bus) { struct spi_slave *slave = dev_get_parent_priv(bus); @@ -134,8 +128,6 @@ static int xilinx_spi_probe(struct udevice *bus) struct xilinx_spi_priv *priv = dev_get_priv(bus); struct xilinx_spi_regs *regs = priv->regs;

•   priv->regs = (struct xilinx_spi_regs *)xilinx_spi_base_list[bus->seq];
  

•   writel(SPISSR_RESET_VALUE, &regs->srr);
  
    return 0;
  

@@ -306,6 +298,18 @@ static const struct dm_spi_ops xilinx_spi_ops = { .set_mode = xilinx_spi_set_mode, };

+static int xilinx_spi_ofdata_to_platdata(struct udevice *bus) +{

•   struct xilinx_spi_priv *priv = dev_get_priv(bus);
  

•   priv->regs = (struct xilinx_spi_regs *)dev_get_addr(bus);
  

Use probe directly instead of platdata, usually *_ofdata_to_platdata have plat details those are assigned in priv in probe call. assigning priv data usually does in probe.

thanks!