On Sat, 2019-10-12 at 01:28 +0800, Tom Rini wrote:
On Wed, Sep 11, 2019 at 07:14:59PM +0800, mingming lee wrote:
This adds a general board file based on MT8518 SoCs from MediaTek.
Apart from the generic parts (cpu) we add some low level init codes and initialize the early clocks.
This commit is adding the basic boot support for the MT8518 eMMC board.
Signed-off-by: mingming lee mingming.lee@mediatek.com
OK, there's a few problems here:
[snip]
+int board_init(void) +{
- /* address of boot parameters */
- gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;
- printf("gd->fdt_blob is %p\n", gd->fdt_blob);
Please remove this (and audit the series for other) bring-up debug printfs that we shouldn't need anymore.
- return 0;
+}
+int board_late_init(void) +{
- /*to load environment variable from persistent store*/
- gd->env_valid = 1;
- env_relocate();
- return 0;
+}
Er, do you really need this?
[snip]
+/* Machine ID */ +#define CONFIG_MACH_TYPE 8518 +#define CONFIG_SYS_NONCACHED_MEMORY BIT(20)
CONFIG_MACH_TYPE is not relevant to aarch64 platforms (it's for pre-device tree boards) and 'BIT(20)' isn't a valid value for CONFIG_SYS_NONCACHED_MEMORY (and leads to a warning a build).
Thanks!
Thank you for your advice.I would modify those issues in the next Version. For the debug info using API printf,I would modify it to the API debug() For the API board_late_init and define CONFIG_MACH_TYPE,I would delete it. For BIT(20), I used to use SZ_1M,it also have warning.I think I would modify it to 0x100000.