Re: [U-Boot] [PATCH] arm: mvebu: armada-370-xp.dtsi: Add "u-boot, dm-pre-reloc" to "internal-regs"

On 11.05.19 02:09, Chris Packham wrote:

On Fri, 10 May 2019, 11:34 PM Stefan Roese, <sr@denx.de mailto:sr@denx.de> wrote:

Without this U-Boot specific property, booting on Armada XP theadorable
fails in SPL. All nodes in the "internal-regs" (simple-bus) DT node are
not scanned, so the UART node is missing (and others).

I'm not adding this property in an *u-boot.dtsi file, since there is
none matching the generic rules for all files including this dtsi
file. So to not miss any of the boards using this dtsi file, I'm
adding it to this file directly, which makes the Linux merge a less
easy unforunately.

Signed-off-by: Stefan Roese <sr@denx.de <mailto:sr@denx.de>>
Cc: Chris Packham <judge.packham@gmail.com <mailto:judge.packham@gmail.com>>
Cc: Marek Behún <marek.behun@nic.cz <mailto:marek.behun@nic.cz>>

Thanks. Is this a regression from my last sync? The only Armada XP like platform I had access to was msys and that doesn't use SPL (yet).

I'm not 100% sure if its only a regression caused by your DT sync or also by this patch:

c7a88dae "dm: remove pre reloc properties in SPL and TPL device tree"

I stopped debugging at some point, once I had the node enabled in the SPL DT again.

Reviewed-by: Chris Packham <judge.packham@gmail.com mailto:judge.packham@gmail.com>

Thanks, Stefan