On Thursday 16 July 2009 16:06, Stefan Roese wrote:
On Thursday 16 July 2009 15:47:17 Matthias Fuchs wrote:
"bootstrap" is pretty generic. can you pick something a little more descriptive/specific ?
I agree with Mike. Please change the command name and the files to something more specific. How about "4xxbootstrap"? Or "4xxstrap"?
To long for my taste.
Any other good ideas about this naming welcome. :)
We called this command "sbe" on our PMC440 (440EPx) and upcoming PMC405DE (405EP) board. I must admit that I forget its meaning. Probably something like 'setup bootstrap eeprom'.
If you already forgot what it's supposed to mean, then it definitely is not a good name. Better a bit longer and more descriptive.
I like 'sbe' - it short and I even gave it a meaning :-)
But it works a little mit different that the bootstrap command.
It would be great if you could merge/consolidate such 4xx custom commands into this common one.
I was a little inspired by the sequoia code that also comes with a bootstrap command. So please don't ask me to merge it into common code. But your finger on your own nose.
Does you command support more features? What's the main difference?
Much simpler. Just call sbe with a descriptive argument like a CPU frequency or something like '667-66' on a 440EPx target with 66Mhz PCI clock or 'sr-test-only' for something you will remove later :-). This has two advantages over just using numbers: You can remove configurations without making the following configs in the table moving to the front and its a little more secure meaning you have to type a couple of valid character to reconfigure the clocking. Just using "bootstrap 5" is error-prone.
Well, I like my syntax and behavior, but I do not want to totally dismiss Dirk's idea as long as I can keep my sbe command :-)
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot