Hi Wolfgang,
as you might have noticed the DU440 board is havily based on seuqoia code. Nearly all of your comments apply to that board as well. I thought of the sequoia code as exemplary reference code. And I prefer not to reformat comments when copy and pasting from one board to another.
But if you really insist of these changes I will change the patch.
On Sunday 13 January 2008 23:08, Wolfgang Denk wrote:
Ummm...
#include <asm/bitops.h> ... size_val = ffs(gd->bd->bi_flashsize) - 21;
seems more straigtforward to me...
Good idea. Thanks.
+#if 1
Please remove the '#if 1' as it's redundant.
Ack.
...
+#if 0 +/*
- test commands for SM722 2D acceleration
- */
...
+U_BOOT_CMD(
- gfxline, CFG_MAXARGS, 1, do_gfxline,
- "gfxline - draw line\n",
- "[color] [x1] [y1] [x2] [y2]\n"
- );
+#endif
Please remove the dead code.
Please not. The DU440 board will get an updated smi_lynxem driver with support for the SM722 soon. My current hack is to dirty for submission and I just got some more register dumps from SM to support more videomodes. I will need this commented out code to test it. I plan to remove it later.
diff --git a/board/esd/du440/init.S b/board/esd/du440/init.S new file mode 100644 index 0000000..1e15e72 --- /dev/null +++ b/board/esd/du440/init.S @@ -0,0 +1,80 @@ +/*
- See file CREDITS for list of people who contributed to this
- project.
- This program is free software; you can redistribute it and/or
- modify it under the terms of the GNU General Public License as
- published by the Free Software Foundation; either version 2 of
- the License, or (at your option) any later version.
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
- You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- MA 02111-1307 USA
- */
Copyright missing.
You probably may want to adjust the (C) messages in some other files, too.
Ack. May I put my name on it? The source of this code has no copyright either.
diff --git a/board/esd/du440/u-boot.lds b/board/esd/du440/u-boot.lds new file mode 100644 index 0000000..a423f98 --- /dev/null +++ b/board/esd/du440/u-boot.lds
...
- __bss_start = .;
- .bss :
NOLOAD attribute missing. Please fix.
This is new to me. But I just noticed that all other boards have been updated according to this. So will I.
I will update my patches. Perhaps you can comment on my comments above.
Matthias