Hi Detlev,
On Wednesday 30 January 2008, Detlev Zundel wrote:
IIRC, I didn't even try to apply this version of the patch. I tried to review it and failed because the patch was "unreadable" for me.
Hm, then I am not sure what you meant by this passage from your mail:
This option you used to make the patches smaller (find-copies or something like this) really makes reviewing not easy. And additionally the patch doesn't apply anymore, since the reference (sequoia) has
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Ahh. You are right of course. The origin (Sequoia) changed and therefor the patch didn't apply anymore.
changed in my non publiched branch already. Another reason why I would like to see a 100k size limit on this list.
So Matthias, could you please resend these 3 patches without this option to me directly?
I don't remember any problems applying those kind of patches. And I'm pretty sure that I didn't use the "-3" option.
Regardless of previous experiences, just remember to give "git-am -3" a try once git-am without it fails.
Ok. But I hope not to see such patches anymore since they are not reviewable. At least not for me.
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================