Hi Joe,
On Tue, Mar 10, 2020 at 2:45 PM Joe Hershberger joe.hershberger@ni.com wrote:
I tried to apply this but it breaks the unit tests. I guess you didn't try "ut dm" in sandbox?
https://travis-ci.org/jhershbe/u-boot/builds/660395782
Please test those and update the tests to pass with your change.
Ok, I will revisit this patch after 2020.04.
I think we should probably let net_random_ethaddr() run unconditionally:
--- a/net/eth-uclass.c +++ b/net/eth-uclass.c @@ -547,15 +547,9 @@ static int eth_post_probe(struct udevice *dev) dev->name); } else if (is_zero_ethaddr(pdata->enetaddr) || !is_valid_ethaddr(pdata->enetaddr)) { -#ifdef CONFIG_NET_RANDOM_ETHADDR net_random_ethaddr(pdata->enetaddr); printf("\nWarning: %s (eth%d) using random MAC address - %pM\n", dev->name, dev->seq, pdata->enetaddr); -#else - printf("\nError: %s address not set.\n", - dev->name); - return -EINVAL; -#endif }
eth_write_hwaddr(dev);
Thanks