25 Jun
2013
25 Jun
'13
8:27 p.m.
Dear Frederic Leroy,
In message 1372178945-11528-3-git-send-email-fredo@starox.org you wrote:
diff --git a/board/LaCie/common/common.c b/board/LaCie/common/common.c index a62bf9f..d828685 100644 --- a/board/LaCie/common/common.c +++ b/board/LaCie/common/common.c
...
- #ifndef CONFIG_CLOUDBOX
...
- #else
...
- #endif
Preprocessor statements must start in column 1; please fix.
Also, can we not avoid the #ifdef alltogether by providing a #define for the register number to read? This could then be done in the board config file.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Children begin by loving their parents. After a time they judge them.
Rarely, if ever, do they forgive them. - Oscar Wilde