On Wed, Nov 30, 2016 at 1:02 PM, Phil Edworthy phil.edworthy@renesas.com wrote:
Hi Jagan,
On 30 November 2016 04:59, Jagan Teki wrote:
On Tue, Nov 29, 2016 at 6:28 PM, Phil Edworthy phil.edworthy@renesas.com wrote:
Most of the code already uses #defines for the bit value, rather than the shift required to get the value. This changes the remaining code over.
Whislt at it, fix the names of the "Rd Data Capture" register defs.
Signed-off-by: Phil Edworthy phil.edworthy@renesas.com Acked-by: Marek Vasut marek.vasut@gmail.com
<snip>
I've commented about this change [1]?
[1] https://www.mail-archive.com/u-boot@lists.denx.de/msg232120.html
Yes, I fixed that in a separate patch, see https://www.mail-archive.com/u-boot@lists.denx.de/msg232489.html
I did it in a separate patch because this patch is purely about replacing the definitions of bit shifts with BIT(x).
Reviewed-by: Jagan Teki jagan@openedev.com
thanks!