Hi Robert and Bryan,
On Jun 15, 2024 at 21:30:55 -0500, Robert Nelson wrote:
On Sat, Jun 15, 2024 at 8:55 PM Bryan Brattlof bb@ti.com wrote:
On June 13, 2024 thus sayeth Dhruva Gole:
The Kernel Image and DTB files are supposed to be picked from the rootfs of the SD Card, this fails in legacy boot flow because bootpart is set to 1:1. Fix it.
Fixes: a200f428b5b21 ("board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file") Signed-off-by: Dhruva Gole d-gole@ti.com
board/beagle/beagleplay/beagleplay.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/beagle/beagleplay/beagleplay.env b/board/beagle/beagleplay/beagleplay.env index bbf6b925d02c..190181c8ad0c 100644 --- a/board/beagle/beagleplay/beagleplay.env +++ b/board/beagle/beagleplay/beagleplay.env @@ -11,7 +11,7 @@ set_led_state_start_load=led led-0 on; led led-1 off; led led-2 on; led led-3 off; led led-4 on boot=mmc mmcdev=1 -bootpart=1:1 +bootpart=1:2 bootdir=/boot boot_targets=mmc1 mmc0 bootmeths=script extlinux efi pxe
Shouldn't the fix be to just drop 'script' from bootmeths. These TI scripts needed to go away years ago.
I agree! nuke the non bootmeth's. ;)
People are still using legacy bootmethods out there. I think the cleanup will still take time till everyone is on the same page and I feel like beagle being a community platform, doesn't mandate to use a "fixed" boot flow atleast until stdboot is fully at feature parity with legacy boot. Some users may still care for the legacy boot method.
From the discussions so far it seems evident to me that the BeagleBone
debian images are anyway going to be unaffected by this change so that removes the question of it causing any regressions on that end.
People who do want to use legacy boot and pick kernel image and DTB from their root partitions will benefit from this change for sure.
So I don't really see the need/argument here to not go ahead with this patch?
We can definitely have separate discussion around whether we need to remove legacy flow bits from upstream U-Boot, but no reason to keep this small fix blocked till we have those discussions is what I feel.