Re: [U-Boot] arm: socfpga: set skew settings for ethernet phy

Dear Pavel Machek,

In message 20141113120956.GB30779@amd you wrote:

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 507b9a3..06a31b0 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -112,17 +112,46 @@ static int ksz9021_phy_extwrite(struct phy_device *phydev, int addr, return ksz9021_phy_extended_write(phydev, regnum, val); }

Please don't add excessive white space / blank lines.

• printf("ksz9021: configuring\n");
• printf("Configuring PHY skew timing for %s\n",

•       phydev->drv->name);
  

Should these eventually be changed into debug() ?

Output gets really noisy otherwise.

if (getenv("disable_giga"))

Should we not rather use the standard "hwconf" approach here?

Best regards,

Wolfgang Denk