Hi Wolfgang,
Huh.. my bad, I actually had my tabs set to 4 on the screen.
Can you at least consider allowing me to use spaces to indent that header file? Placing the entire u-boot environment variables in one string without any indentation of sorts would make that code highly un-readable. And with indents or 8, impossible to fit. But the moment I use space tabs, the tool also complains "please don't use spaces".... I feel sort-of out of options here other than going for a flat un-readable environment variables.
If not, I'll just remove the text indents tabs added for readability and resubmit the patch.
Cheers, Gilles .
On Feb 2, 2015, at 14:28 , Wolfgang Denk wd@denx.de wrote:
Dear Gilles,
In message 3037D005-FDEE-4FCB-AD36-1977E2E4BDC4@gigadevices.com you wrote:
I ran the patman tool to generate this patch which appears to throw a few (erroneous) warnings about lines over 80 but, there are no lines over 80... not sure what the problem is there. Also threw a few "alignment should match open parenthesis" but the code is clean.
Sure there are many too long lines. I can only speculate that you are counting TAB characters as one character, but they make up for indentation of up to 8 columns. And it's the columns in the display that count, not the number of characters.
Please fix these too long lines. Also, please do NOT send patches as MIME attachments; see [1] for detailed instructions if needed.
[1] http://www.denx.de/wiki/U-Boot/Patches
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Where would we be without rhetorical questions?