Dear Andy,
In message 18255ae55e4faa5733fb8e93dc8ebbc1559a3694.camel@linux.intel.com you wrote: ...
This converts all x86 boards over to DM sysreset.
-int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) -{
- printf("resetting ...\n");
- /* wait 50 ms */
- udelay(50000);
I am willing to bet that the delay here is a dirty surrogate for flushing/closing the standard output channel, i. e. we wait until the characters have actually been set over the serial console.
Don't we have a way to close() the device in DM (remove ?) ?
First of all, in some cases would be good to have at least a debug message that we got into do_reset().
This should not only be a debug message, but a standard message; actually even something that goes to STDERR.
Second, I didn't test if udelay() + disable_interrupts() make any difference. So, I would leave them for now.
See above... I think the delay should be replaced by the proper way to close the device in DM (remove?).
Best regards,
Wolfgang Denk