Re: [U-Boot] [PATCH] watchdog: Add Cadence watchdog driver

Hi,

On 26.3.2018 21:48, Heinrich Schuchardt wrote:

Hello Shreenidhi,

with the patch you added the CONFIG_WATCHDOG to drivers/watchdog/Kconfig.

Could you, please, add a description of CONFIG_WATCHDOG to doc/README.watchdog.

If you look at the history then last reasonable change was done in 2015 by Simon. Content of this file could be most likely just added to Kconfig and it can be removed.

In include/watchdog.h I found this: "CONFIG_HW_WATCHDOG and CONFIG_WATCHDOG can't be used together."

So shouldn't CONFIG_WATCHDOG depend on !HW_WATCHDOG in Kconfig? This avoids a possible error at compile time.

!HW_WATCHDOG should be probably the part of config WDT not just for CDNS.

Thanks, Michal