Re: [U-Boot] [PATCH 2/2] mx6cuboxi: Add support for sata

On Tue, May 16, 2017 at 2:50 AM, Jonathan Gray jsg@jsg.id.au wrote:

Comment was intended to be mx6d/mx6q?

Though the test here may not be needed as setup_sata() returns early if not available. And mx6cuboxi.c wouldn't need to be updated here if a i.MX 6DualPlus or i.MX 6QuadPlus board from SolidRun shows up at some point in the future.

u-boot/arch/arm/imx-common/sata.c

int setup_sata(void) { struct iomuxc *const iomuxc_regs = (struct iomuxc *)IOMUXC_BASE_ADDR; int ret;

    if (!is_mx6dq() && !is_mx6dqp())
            return 1;

Good points!

Peter, please send a v2 taking into account Jonathan's comments. Thanks