Re: [U-Boot-Users] [PATCH] fix system config overwrite @ MPC834x and MPC8313

On Mon, 23 Jun 2008 11:40:56 +0200 Andre Schwarz andre.schwarz@matrix-vision.de wrote:

During 83xx setup the "System I/O configuration register high" gets overwritten with user defined value if CFG_SICRH is defined.

Regarding to the MPC834x manual (Table 5-28 reve.1) bits 28+29 of SICRH must keep their reset value regardless of configuration.

On my board (using RGMII) those bits are set after reset - yet it's unclear where they come from.

The patch keeps both bits on MPC834x and MPC8313.

Signed-off-by: Andre Schwarz andre.schwarz@matrix-vision.de

this has been applied after a slight rewrite to not cause the following:

cpu_init.c: In function ‘cpu_init_f’: cpu_init.c:62: warning: unused variable ‘tmp_sicrh’

Thanks Andre,

Kim