Re: [U-Boot-Users] [PATCH] CFI: synchronize command offsets with Linux CFI driver

On Tuesday 11 December 2007, Bartlomiej Sieka wrote:

...

Why not like this:

			if (((info->chipwidth == FLASH_CFI_BY8) &&
			     (info->interface == FLASH_CFI_X8X16)) ||
			    ((info->chipwidth == FLASH_CFI_BY16) &&
			     (info->interface == FLASH_CFI_X16X32))) {
				/*
				 * Compatibility mode:
				 * x8/x16 in x8 mode or
				 * x16/x32 in x16 mode
				 */
				info->addr_unlock1 = 0xaaa;
				info->addr_unlock2 = 0x555;
			} else {
				/* default */
				info->addr_unlock1 = 0x555;
				info->addr_unlock2 = 0x2aa;
			}

I copied the code from Linux CFI driver and kept it as is (modulo #define names).

Ahh, I see. Even this ugly "{" in the next line is present in the Linux code.

I'm fine with either of the two forms, although I think that there is some benefit in keeping borrowed code as intact as possible.

Right. So if nobody else protests here, I'll add your original version to the cfi repo soon.

Thanks.

Best regards, Stefan

===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================