Thanks,
From: Eugeniu Rosca erosca@de.adit-jv.com Sent: lundi 6 juillet 2020 08:47
Hi Patrick,
On Fri, Jul 03, 2020 at 04:40:28PM +0000, Patrick DELAUNAY wrote:
From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Eugeniu Rosca Sent: samedi 11 janvier 2020 00:30
Hi Tom,
On Fri, Jan 10, 2020 at 04:50:52PM -0500, Tom Rini wrote:
On Tue, Dec 24, 2019 at 05:51:08PM +0100, Eugeniu Rosca wrote:
Signed-off-by: Eugeniu Rosca erosca@de.adit-jv.com Reviewed-by: Sam Protsenko semen.protsenko@linaro.org
Applied to u-boot/master, thanks!
Thanks for merging!
For the planned update of the command adtimg:
[6] Soon-to-be-provided "by id|rev" add-on functionality adtimg get dt --id=<id> --rev=<rev> [avar [svar [ivar]]]
- Get DT address/size/index by id|rev fields
Do you have plan to upstream this code or it is available in downstream ?
Because stm32mp1 platform needs this feature
Good to hear that the features are used by people out there.
We code in downstream [1] based on v2020.01 almost the same command but based on the old usage = [2]
After a quick look, this is certainly missing the latest vanilla patches, so is out of sync with mainline.
dtimg getindex <addr> <board_id> <board_rev> [varname] - get index of FDT in the image, by board identifier and revision <addr>: image address in RAM, in hex <board_id>: board identifier <board_rev>: board revision (0 if not used) [varname]: name of variable where to store index of FDT
So if you have nothing ready, I can update my code with your proposed
parameters.
[1] https://github.com/STMicroelectronics/u-boot/blob/v2020.01-stm32mp/cmd /dtimg.c [2] https://github.com/STMicroelectronics/u-boot/commit/21b57a166e73a8457d 4caea6a1d37f1f3fda3d45
You would need to rebase these commits first. A quicker route is to just take my patches available below: https://github.com/erosca/u-boot/commits/master_adtimg_id_rev
These have been extensively tested and are now running in development/production systems for months w/o any issues.
Do you have any comments concerning the two commits below? https://github.com/erosca/u- boot/commit/936a08faaf3f485527e2d1cfb8a53dcf44e17b3a https://github.com/erosca/u- boot/commit/e37d090dabb6973762376adca5ae10292ca3ba3d
I check the 2 patches, they seems OK.
I just surprized by the '--' for the command parameter because it is unusual in U-Boot commands.
It wasn't enough to have .....<parameter>=<val> as other command (unzip for example) but it is perhaps to late to change again the commands adtimg and it is aligned with "abootimg.c"
For information, I will activate the command ADTIMG for stm32mp32 [1] and update the stm32mp1 downstream android bootcmd to use when they will be available.
But I have don't yet tested them
We do you plan to rebase and upstream these 2 commits ?
[1] = http://patchwork.ozlabs.org/project/uboot/patch/20200706130046.22446-1-patri...
-- Best regards, Eugeniu Rosca
Best regards,
Patrick