Hello Baruch,
Am 02.07.2020 um 21:05 schrieb Baruch Siach:
Hi Heiko,
On Fri, May 15 2020, Heiko Schocher wrote:
save the GPIOD_ flags also in the gpio descriptor.
Signed-off-by: Heiko Schocher hs@denx.de Reviewed-by: Patrick Delaunay patrick.delaunay@st.com Reviewed-by: Simon Glass sjg@chromium.org
This fixes SD card access on Hummingboard2. Current master uses the wrong out polarity to control the SD card power regulator.
Tested-by: Baruch Siach baruch@tkos.co.il
Should go to v2020.07 I believe.
Toms decision... but it seems this bug pops up on more and more boards, as also some days ago Walter reported that this patch fixes a problem on iMX6 Hummingboard with mmc...
There is also a v6 version of this patchset ... see:
http://patchwork.ozlabs.org/project/uboot/list/?series=178637
One more comment below.
@@ -614,10 +618,6 @@ int dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags) flags |= desc->flags; ret = _dm_gpio_set_dir_flags(desc, flags);
- /* update the descriptor flags */
- if (ret)
desc->flags = flags;- return ret;
You can just do
return _dm_gpio_set_dir_flags(desc, flags);
here instead.
Yes!
I would let the patch as it is and (I or you?) send a fix on top?
bye, Heiko