Dear Richard Retanubun,
In message 4AE5EDCC.5050205@RuggedCom.com you wrote:
From 2b9f89f5d0538e44ebbe66236cd9b6be4ee902e3 Mon Sep 17 00:00:00 2001 From: Richard Retanubun RichardRetanubun@RuggedCom.com Date: Mon, 26 Oct 2009 14:16:03 -0400 Subject: [PATCH] Added a weak board_reset function to allow custom reset.
This patch adds a board_reset function to allow boards to specify their own custom reset sequence (e.g. resetting by timing out watchdog).
Signed-off-by: Richard Retanubun RichardRetanubun@RuggedCom.com
Based on Mike Frysinger's suggestion on: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/70304
cpu/mpc83xx/cpu.c | 6 ++++++ cpu/mpc83xx/cpu.h | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 0 deletions(-) create mode 100644 cpu/mpc83xx/cpu.h
Instead of adding yet another implementation of the same code I would like to see at least common code being used within an architecture; for PowerPC, we already have different implementations in "cpu/ppc4xx/cpu.c" and in "cpu/mpc86xx/cpu.c".
Not to mention that "cpu/arm920t/at91rm9200/reset.c" and "cpu/blackfin/cpu.h" / "cpu/blackfin/reset.c" have such code, too.
Can we please come up with one common implementation?
Thanks.
Best regards,
Wolfgang Denk