Re: [U-Boot] [PATCH]: FFS/UFS filesystems support

Dear Stanislav,

In message 20081103155448.49935b1d.stas@FreeBSD.org you wrote:

There's a new version of the patch. I've also changed the license to GPL where possible.

Sorry, but I'm still concerned about the licensing.

diff -r 83d0dd6dceee fs/ffs/ffs.c

• --- /dev/null Thu Jan 01 00:00:00 1970 +0000

+++ b/fs/ffs/ffs.c Mon Nov 03 15:49:29 2008 +0300 @@ -0,0 +1,670 @@ +/*-

• • Copyright (c) 2008 Stanislav Sedov stas@FreeBSD.org.
• • All rights reserved.
• • Copyright (c) 2002 McAfee, Inc.
• • All rights reserved.
• • This software was developed for the FreeBSD Project by Marshall
• • Kirk McKusick and McAfee Research,, the Security Research Division of
• • McAfee, Inc. under DARPA/SPAWAR contract N66001-01-C-8035 ("CBOSS"), as
• • part of the DARPA CHATS research program
• • Redistribution and use in source and binary forms, with or without
• • modification, are permitted provided that the following conditions
• • are met:
• • 1. Redistributions of source code must retain the above copyright
• • notice, this list of conditions and the following disclaimer.
• • 2. Redistributions in binary form must reproduce the above copyright
• • notice, this list of conditions and the following disclaimer in the
• • documentation and/or other materials provided with the distribution.

That means, that all U-Boot documetnation, and all documentation of devices using U-Boot, must be augmented by a whole list of copyright notice, this list of conditions and the disclaimer...

Especially intersting is this file, which includes duplicated entries:

diff -r 83d0dd6dceee include/ffs_dinode.h

• --- /dev/null Thu Jan 01 00:00:00 1970 +0000

+++ b/include/ffs_dinode.h Mon Nov 03 15:49:29 2008 +0300 @@ -0,0 +1,191 @@ +/*-

• • Copyright (c) 2002 Networks Associates Technology, Inc.
• • All rights reserved.
• • This software was developed for the FreeBSD Project by Marshall
• • Kirk McKusick and Network Associates Laboratories, the Security
• • Research Division of Network Associates, Inc. under DARPA/SPAWAR
• • contract N66001-01-C-8035 ("CBOSS"), as part of the DARPA CHATS
• • research program
• • Redistribution and use in source and binary forms, with or without
• • modification, are permitted provided that the following conditions
• • are met:
• • 1. Redistributions of source code must retain the above copyright
• • notice, this list of conditions and the following disclaimer.
• • 2. Redistributions in binary form must reproduce the above copyright
• • notice, this list of conditions and the following disclaimer in the
• • documentation and/or other materials provided with the distribution.

Clauses 1 + 2.

• • THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
• • ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
• • IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
• • ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
• • FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
• • DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
• • OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
• • HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
• • LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
• • OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
• • SUCH DAMAGE.
• • Copyright (c) 1982, 1989, 1993
• • The Regents of the University of California. All rights reserved.
• • (c) UNIX System Laboratories, Inc.
• • All or some portions of this file are derived from material licensed
• • to the University of California by American Telephone and Telegraph
• • Co. or Unix System Laboratories, Inc. and are reproduced herein with
• • the permission of UNIX System Laboratories, Inc.
• • Redistribution and use in source and binary forms, with or without
• • modification, are permitted provided that the following conditions
• • are met:
• • 1. Redistributions of source code must retain the above copyright
• • notice, this list of conditions and the following disclaimer.
• • 2. Redistributions in binary form must reproduce the above copyright
• • notice, this list of conditions and the following disclaimer in the
• • documentation and/or other materials provided with the distribution.
• • 3. The names of the authors may not be used to endorse or promote
• • products derived from this software without specific prior written
• • permission.

Clauses 1 + 2 + 3.

• • THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
• • ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
• • IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
• • ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
• • FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
• • DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
• • OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
• • HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
• • LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
• • OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
• • SUCH DAMAGE.

And here:

• --- /dev/null Thu Jan 01 00:00:00 1970 +0000

+++ b/include/ffs_fs.h Mon Nov 03 15:49:29 2008 +0300 @@ -0,0 +1,616 @@ +/*-

• • Copyright (c) 1982, 1986, 1993
• • The Regents of the University of California. All rights reserved.
• • Redistribution and use in source and binary forms, with or without
• • modification, are permitted provided that the following conditions
• • are met:
• • 1. Redistributions of source code must retain the above copyright
• • notice, this list of conditions and the following disclaimer.
• • 2. Redistributions in binary form must reproduce the above copyright
• • notice, this list of conditions and the following disclaimer in the
• • documentation and/or other materials provided with the distribution.
• • 4. Neither the name of the University nor the names of its contributors
• • may be used to endorse or promote products derived from this software
• • without specific prior written permission.

Here we hace 1., 2. and 4., but 3. is missing?

It seems that this was the "obnoxious BSD advertising clause", right? [See http://www.gnu.org/philosophy/bsd.html]

I am concerned if the removal of this clause was legally justified, and confirmed by the original authors and copyright holders?

Best regards,

Wolfgang Denk