Hi Bin,
On 25/03/2021 15:49, Neil Armstrong wrote:
With the introduction of pcie_dw_rockchip, and need to support the DW PCIe in the Amlogic AXG & G12 SoCs, most of the DW PCIe helpers would be duplicated.
This introduce a "common" DW PCIe helpers file with common code merged from the dw_ti and dw_rockchip drivers and adapted to fit with the upcoming dw_meson.
The following changes will switch the dw_ti and dw_rockchip, and introduce a new driver to support the Amlogic AXG & G12 SoCs using these new common helpers.
The dw_meson has been validated, but the dw_ti and dw_rockchip would need testing on hardware to validate nothing has been broken.
How should be proceed ? I can't possibly test patches 2 & 3, but Green has tested it on Sifive, should patch 1 & 4 be merged then we should wait feedback from the Ti & Rockchip owners ?
Neil
Changes since v1:
- added prefetch memory region support
- switched to __iomem
- fixed circular dependency for PCI_KEYSTONE
Neil Armstrong (4): pci: add common Designware PCIe functions pci: pcie_dw_ti: migrate to common Designware PCIe functions pci: pcie_dw_rockchip: migrate to common Designware PCIe functions pci: add Amlogic Meson Designware PCIe controller
drivers/pci/Kconfig | 16 +- drivers/pci/Makefile | 2 + drivers/pci/pcie_dw_common.c | 366 +++++++++++++++++++++++++ drivers/pci/pcie_dw_common.h | 155 +++++++++++ drivers/pci/pcie_dw_meson.c | 459 ++++++++++++++++++++++++++++++++ drivers/pci/pcie_dw_rockchip.c | 472 ++------------------------------- drivers/pci/pcie_dw_ti.c | 444 +++---------------------------- 7 files changed, 1062 insertions(+), 852 deletions(-) create mode 100644 drivers/pci/pcie_dw_common.c create mode 100644 drivers/pci/pcie_dw_common.h create mode 100644 drivers/pci/pcie_dw_meson.c