From: Quentin Schulz quentin.schulz@theobroma-systems.com
Since both functions share a similar goal and env_get_default_into can do what env_get_default wants to do with specific arguments, let's make env_get_default call env_get_default_into so as to avoid code duplication.
Cc: Quentin Schulz foss+uboot@0leil.net Reviewed-by: Tom Rini trini@konsulko.com Reviewed-by: Kever Yang kever.yang@rock-chips.com Signed-off-by: Quentin Schulz quentin.schulz@theobroma-systems.com --- env/common.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/env/common.c b/env/common.c index ebcb10854d8..beebbd163bf 100644 --- a/env/common.c +++ b/env/common.c @@ -351,9 +351,11 @@ bool env_get_autostart(void) */ char *env_get_default(const char *name) { - if (env_get_from_linear(default_environment, name, - (char *)(gd->env_buf), - sizeof(gd->env_buf)) >= 0) + int ret; + + ret = env_get_default_into(name, (char *)(gd->env_buf), + sizeof(gd->env_buf)); + if (ret >= 0) return (char *)(gd->env_buf);
return NULL;