Re: [U-Boot] [PATCH 1/3] mpc85xx: Add inline GPIO acessor functions

On Oct 18, 2011, at 10:19 PM, Mike Frysinger wrote:

On Tuesday 18 October 2011 19:41:22 Kyle Moffett wrote:

...

--- a/README +++ b/README

• 85xx CPU Options:

• CONFIG_MPC85XX_GENERIC_GPIO
  

• Provide a generic gpio_request() interface to the onboard
  

• processor GPIOs in the MPC85XX-series chips.
  

do you really need a CONFIG knob for this ? defining this adds no overhead that i can see.

I agree, wasn't paying attention that this is just in a .h, so lets remove the CONFIG_ option bits (both in README and in .h)

...

--- /dev/null +++ b/arch/powerpc/include/asm/mpc85xx_gpio.h

missing #ifdef protection against multiple inclusion

please fix.

- k