On Mon, Nov 28, 2011 at 9:37 AM, Ilya Yanok yanok@emcraft.com wrote:
This patch adds support for the HTKW mcx AM3517-based board. Serial, Ethernet, NAND, MMC, RTC, EHCI USB host and both NAND and MMC SPLs are supported.
[snip]
+#if defined(CONFIG_GENERIC_MMC) && defined(CONFIG_OMAP_HSMMC) && \
- !defined(CONFIG_SPL_BUILD)
OMAP_HSMMC requires GENERIC_MMC so just defined(CONFIG_OMAP_HSMMC) && !definedCONFIG_SPL_BUILD) like the rest is all that's needed.
[snip to config header]
+#undef CONFIG_USE_IRQ /* no support for IRQs */
Should be removed, isn't used.
+/*
- DDR related
- */
+#define CONFIG_OMAP3_MICRON_DDR /* Micron DDR */
This is unused with SPL.
+#define CONFIG_SYS_MAXARGS 32 /* max number of command */
- /* args */
Are you sure you don't just need 16 here? This is arguments to u-boot commands and not related to being able to pass in lots of stuff to the kernel via command line. (And yes, I know where you got this from, putting those to 16 is on my low hanging fruit list).
And from that same source you copy/pasted a few incorrect multiline comments (the /* ------... ones).
+#define CONFIG_STACKSIZE (128 << 10) /* regular stack 128 KiB */ +#ifdef CONFIG_USE_IRQ +#define CONFIG_STACKSIZE_IRQ (4 << 10) /* IRQ stack 4 KiB */ +#define CONFIG_STACKSIZE_FIQ (4 << 10) /* FIQ stack 4 KiB */ +#endif
And given we don't define CONFIG_USE_IRQ..
+#define CONFIG_SPL_MAX_SIZE 0xB400 /* 45 K */
Better as (45 << 10).