On 09/12/2012 04:10 PM, Tom Warren wrote:
diff --git a/board/nvidia/cardhu/cardhu.c b/board/nvidia/cardhu/cardhu.c
+/*
- Routine: gpio_config_uart
- Description: Does nothing on Cardhu - no conflict w/SPI.
- */
+void gpio_config_uart(void) +{ +}
For reference, personally, I'd expect to see the UART pinmux set up there (at least after Lucas's cleanup of GPIO/UART/pinmux functions patch).
+#ifdef CONFIG_TEGRA_MMC +/*
- Routine: pin_mux_mmc
- Description: setup the pin muxes/tristate values for the SDMMC(s)
- */
+static void pin_mux_mmc(void) +{
- funcmux_select(PERIPH_ID_SDMMC4, FUNCMUX_SDMMC4_ATB_GMA_GME_8_BIT);
- funcmux_select(PERIPH_ID_SDMMC3, FUNCMUX_SDMMC3_SDB_4BIT);
...
+#ifdef CONFIG_USB_EHCI_TEGRA +void pin_mux_usb(void) +{
- /* For USB's GPIO PD0. For now, since we have no pinmux in fdt */
- pinmux_tristate_disable(PINGRP_SLXK);
+} +#endif
None of that would compile if the options were enabled. I'd definitely suggest removing since it needs to be completely re-written anyway. Otherwise, someone else isn't going to know and it'll seem like reference code.
diff --git a/board/nvidia/cardhu/pinmux-config-common.h b/board/nvidia/cardhu/pinmux-config-common.h
I don't think anything in this file is actually used?