On 3/9/20 9:09 AM, Peng Fan wrote:
Hi Jaehoon,
Subject: [PATCH 3/3] mmc: Kconfig: remove MMC_BROKEN_CD configuration
Remove MMC_BROKEN_CD configuration. It doesn't need to use configuration, instead use broken-cd property.
Will this cause issue if board not use dts saying in SPL stage?
I didn't test on board, but if it will be set to MMC_CAPS_NEEDS_POLL, it will be working fine. In ci200, i had added MMC_CAP_NEEDS_POLL by default. (So it will be working..) But in fsl_esdhc's case, i didn't touch.. So i need to check it more.
Will resend patch this after considering SPL.
Best Regards, Jaehoon Chung
Regards, Peng.
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com
configs/brppt2_defconfig | 1 - configs/ci20_mmc_defconfig | 1 - configs/meerkat96_defconfig | 1 - drivers/mmc/Kconfig | 5 ----- 4 files changed, 8 deletions(-)
diff --git a/configs/brppt2_defconfig b/configs/brppt2_defconfig index f94ea28376..5d1dfde36e 100644 --- a/configs/brppt2_defconfig +++ b/configs/brppt2_defconfig @@ -68,7 +68,6 @@ CONFIG_SPL_DM_SEQ_ALIAS=y # CONFIG_SPL_BLK is not set CONFIG_BOOTCOUNT_LIMIT=y CONFIG_SYS_I2C_MXC=y -CONFIG_MMC_BROKEN_CD=y # CONFIG_SPL_DM_MMC is not set CONFIG_FSL_ESDHC=y CONFIG_MTD=y diff --git a/configs/ci20_mmc_defconfig b/configs/ci20_mmc_defconfig index a0b0772f40..f31a3c44f4 100644 --- a/configs/ci20_mmc_defconfig +++ b/configs/ci20_mmc_defconfig @@ -34,7 +34,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y # CONFIG_DM_DEVICE_REMOVE is not set CONFIG_JZ4780_EFUSE=y CONFIG_MMC=y -CONFIG_MMC_BROKEN_CD=y CONFIG_DM_MMC=y # CONFIG_MMC_HW_PARTITIONING is not set CONFIG_MMC_IO_VOLTAGE=y diff --git a/configs/meerkat96_defconfig b/configs/meerkat96_defconfig index 45f12115ba..d358ed23a5 100644 --- a/configs/meerkat96_defconfig +++ b/configs/meerkat96_defconfig @@ -34,7 +34,6 @@ CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="imx7d-meerkat96" CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_NET_RANDOM_ETHADDR=y -CONFIG_MMC_BROKEN_CD=y CONFIG_DM_MMC=y CONFIG_FSL_ESDHC=y CONFIG_MTD=y diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index 2f0eedc22f..3722e7bc13 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -18,11 +18,6 @@ config MMC_WRITE help Enable write access to MMC and SD Cards
-config MMC_BROKEN_CD
- bool "Poll for broken card detection case"
- help
If card detection feature is broken, just poll to detect.config DM_MMC bool "Enable MMC controllers using Driver Model" depends on DM -- 2.25.0