Re: [U-Boot] [PATCH v2]ppc4xx/Canyonlands added USB board callbacks

Hi Stefan and Felix,

Thanks for your inputs. I am releasing v3 with the updates.

Regards, Rup

-----Original Message----- From: Stefan Roese [mailto:sr@denx.de]

isolates USB manipulations such that it is only touched if USB is used by U-Boot.

Thanks. Looks quite good now. Please find a small comment below.

<snip>

diff --git a/include/configs/canyonlands.h

b/include/configs/canyonlands.h

index ac9b3c5..0eee522 100644 --- a/include/configs/canyonlands.h +#define CONFIG_SYS_BCSR3_PCIE 0x10

Hmmm. Which of these defines are really bits and which are offsets for registers? You can remove the register offsets defines, since you're using the struct now. And please use consistent naming, and don't name one bit "CONFIG_SYS_BCSRxxx".