Hi Maxime,
On 21 June 2017 at 01:31, Maxime Ripard maxime.ripard@free-electrons.com wrote:
Hi Simon,
On Mon, Jun 19, 2017 at 11:11:27AM -0600, Simon Glass wrote:
Add a driver-model version of this driver which mostly uses the existing code. The old code can be removed once all boards are switched over.
Signed-off-by: Simon Glass sjg@chromium.org
I'm not sure if you tested that, but we have some code that switches the MMC indices when using both an eMMC and an external MMC.
http://git.denx.de/?p=u-boot.git;a=blob;f=board/sunxi/board.c#l494
This predates my time, but it seems that it was done to have a consistent boot MMC device ID.
I'm not really sure we can get rid of it (even if it creates some issues of it's own), but what would be the impact of a switch to the device model on that logic?
That is a pretty terrible hack. I'm not sure whether it will continue to work with DM. It does still use the device number in the block device, so maybe... Do you have a board would use this?
Regards, Simon