On 12/05/2020 16:09, Tom Rini wrote:
Hi,
On Tue, May 12, 2020 at 03:53:55PM +0100, André Przywara wrote:
On 12/05/2020 15:25, Tom Rini wrote:
On Tue, May 12, 2020 at 03:18:33PM +0100, André Przywara wrote:
On 09/05/2020 15:25, Amit Singh Tomar wrote:
This patch adds node for ethernet controller found on Action Semi OWL S700 SoC.
Since, there is no upstream Linux binding exist for S700 ethernet controller, Changes are put in u-boot specific dtsi file.
But that should not be the S700 SoC .dtsi, instead the cubieboard .dts file, since you specify the PHY mode in here (which is board specific).
The general way to move forward here is that bindings should be getting proposed to Linux and accepted there, and U-Boot can take a WIP of them, that gets updated later on to match, but we shouldn't get it here first.
Yes, this is of course a stop-gap measure, but a useful one: Being able to TFTP a kernel helps with developing the kernel port, especially since U-Boot doesn't support MMC (yet). And there are easier things than pushing a DT binding into the kernel tree without having a Linux driver ready ...
So, we're at -rc2 for v2020.07. The DDR calculation stuff I can see getting pulled in. Is the ethernet driver for this SoC so far from done that it's not ready for linux-next? Things don't have to be in mainline proper, but the expectation is that it's making reasonable progress there and been reviewed so that binding changes between what we take in U-Boot at first and a final re-sync once it is in mainline are minimal.
I don't think there is any particular rush in getting this actually merged. After all it seems like the users of this board can be counted on one hand. I think it's nice to have this on the list, so interested parties can pull it in if there is a need. But we can surely wait how the binding evolves in the kernel tree, though this might take some time.
Cheers, Andre.