On Thu, 5 Nov 2020 at 03:10, Ovidiu Panait ovidiu.panait@windriver.com wrote:
Drop initf_console_record wrapper and call console_record_init directly.
Signed-off-by: Ovidiu Panait ovidiu.panait@windriver.com
common/board_f.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
See below
diff --git a/common/board_f.c b/common/board_f.c index 9f441c44f1..cc4f32f9c3 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -765,15 +765,6 @@ static int initf_bootstage(void) return 0; }
-static int initf_console_record(void) -{ -#if defined(CONFIG_CONSOLE_RECORD) && CONFIG_VAL(SYS_MALLOC_F_LEN)
I wonder if we need the second term? We could make a SPL_CONSOLE_RECORD which depends on SYS_MALLOC_F perhaps?
Regards, Simon
return console_record_init();-#else
return 0;-#endif -}
static int initf_dm(void) { #if defined(CONFIG_DM) && CONFIG_VAL(SYS_MALLOC_F_LEN) @@ -830,7 +821,9 @@ static const init_fnc_t init_sequence_f[] = { bloblist_init, #endif setup_spl_handoff,
initf_console_record,+#if defined(CONFIG_CONSOLE_RECORD) && CONFIG_VAL(SYS_MALLOC_F_LEN)
console_record_init,+#endif #if defined(CONFIG_HAVE_FSP) arch_fsp_init,
#endif
2.17.1