Re: [PATCH v7 8/8] board: gw_ventana: enable MV88E61XX DSA support

After the realization from the v6 review, can you please add to this:

On Wed, Oct 26, 2022 at 09:28:59AM -0700, Tim Harvey wrote:

diff --git a/arch/arm/dts/imx6qdl-gw5904.dtsi b/arch/arm/dts/imx6qdl-gw5904.dtsi index 612b6e068e28..c0790183c013 100644 --- a/arch/arm/dts/imx6qdl-gw5904.dtsi +++ b/arch/arm/dts/imx6qdl-gw5904.dtsi @@ -212,6 +212,27 @@ compatible = "marvell,mv88e6085"; reg = <0>;

• 	mdio {
  

• 		#address-cells = <1>;
  

• 		#size-cells = <0>;
  

• 		sw_phy0: ethernet-phy@0 {
  

• 			reg = <0x0>;
  

• 		};
  

• 		sw_phy1: ethernet-phy@1 {
  

• 			reg = <0x1>;
  

• 		};
  

• 		sw_phy2: ethernet-phy@2 {
  

• 			reg = <0x2>;
  

• 		};
  

• 		sw_phy3: ethernet-phy@3 {
  

• 			reg = <0x3>;
  

• 		};
  

• 	};
  

• ports {
  	#address-cells = <1>;
  	#size-cells = <0>;
  

@@ -219,27 +240,36 @@ port@0 { reg = <0>; label = "lan4";

• 			phy-handle = <&sw_phy0>;
  

phy-mode = "internal";

		};

		port@1 {
			reg = <1>;
			label = "lan3";

• 			phy-handle = <&sw_phy1>;
  

phy-mode = "internal";

		};

		port@2 {
			reg = <2>;
			label = "lan2";

• 			phy-handle = <&sw_phy2>;
  

phy-mode = "internal";

		};

		port@3 {
			reg = <3>;
			label = "lan1";

• 			phy-handle = <&sw_phy3>;
  

phy-mode = "internal";

		};

		port@5 {
			reg = <5>;

• 			label = "cpu";
  		ethernet = <&fec>;
  

• 			phy-mode = "rgmii-id";
  

• 			fixed-link {
  

• 				speed = <1000>;
  

• 				full-duplex;
  

• 			};
  	};
  };
  

  };