Re: [U-Boot-Users] [PATCH] xsengine: Fix no partition type specified, use DOS as default

In message 1192768425-12791-1-git-send-email-plagnioj@jcrosoft.com you wrote:

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com

diff --git a/board/xsengine/flash.c b/board/xsengine/flash.c index 2b9afc7..a188e24 100644 --- a/board/xsengine/flash.c +++ b/board/xsengine/flash.c @@ -46,11 +46,11 @@ unsigned long flash_init (void) for (i = 0; i < CFG_MAX_FLASH_BANKS; i++) { switch (i) { case 0:

• 	flash_get_size ((long *) PHYS_FLASH_1, &flash_info[i]);
  

• 	flash_get_size ((vu_long *) PHYS_FLASH_1, &flash_info[i]);
  flash_get_offsets (PHYS_FLASH_1, &flash_info[i]);
  break;
  

  case 1:

• 	flash_get_size ((long *) PHYS_FLASH_2, &flash_info[i]);
  

• 	flash_get_size ((vu_long *) PHYS_FLASH_2, &flash_info[i]);
  flash_get_offsets (PHYS_FLASH_2, &flash_info[i]);
  

Ummm... you did not mention this change in your Subject.

That's not good. It would be better to split this into 2 independent commits.

Best regards,

Wolfgang Denk