On Sun 2016-01-10 14:45:54, Marek Vasut wrote:
On Sunday, January 10, 2016 at 01:04:17 PM, Pavel Machek wrote:
On Sun 2016-01-10 12:56:15, Pavel Machek wrote:
Hi!
After updating from 2016-rc1, I get this compile error: CC common/main.o drivers/usb/host/dwc2.c: In function 'usb_lowlevel_init': drivers/usb/host/dwc2.c:1028:40: error: 'CONFIG_USB_DWC2_REG_ADDR' undeclared (first use in this function)
priv->regs = (struct dwc2_core_regs *)CONFIG_USB_DWC2_REG_ADDR; ^make mrproper socfpga_cyclone5_config
Fixes the problem.
Well, it "fixes" the problem by not compiling dwc2.
Socfpga clearly wants DWC2:
include/configs/socfpga_common.h:#define CONFIG_USB_DWC2 include/configs/socfpga_common.h:#define CONFIG_USB_GADGET_DWC2_OTG
But does not contain required address:
[pavel@pollux u-boot]$ grep -ri USB_DWC2_REG_ADDR . ./drivers/usb/host/dwc2.c: priv->regs = (struct dwc2_core_regs *)CONFIG_USB_DWC2_REG_ADDR; ./README: CONFIG_USB_DWC2_REG_ADDR
the
physical CPU address of the DWC2 ./include/configs/hikey.h:#define CONFIG_USB_DWC2_REG_ADDR 0xF72C0000 ./include/configs/rpi-common.h:#define CONFIG_USB_DWC2_REG_ADDR 0x3f980000 ./include/configs/rpi-common.h:#define CONFIG_USB_DWC2_REG_ADDR 0x20980000
Plus, make socfpga_cyclone5_config does not enable USB, which is probably error.
SoCFPGA is using USB DM , so these base addresses are pulled from OF and are no longer hard-coded.
Pristine u-boot 2016.01-rc4 compiles fine for CV SoCDK. Can you please test mainline _before_ reporting issues ?
Can you please test mainline before complaining?
With d77a092dd3619ca747fb8290ae8f255e9799aaa6 and attached .config, I get the failure. No, CONFIG_DM_USB is not set in the config, which is probably the problem.
Maybe socfpga should select DM_USB or depend on it?
Pavel