16 May
2004
16 May
'04
11:58 a.m.
On Sat, May 15, 2004 at 07:10:55PM +0200, Wolfgang Denk wrote:
- Patch by Robert Schwebel, 14 May 2004: use config.h (which is needed in serial.c for CFG_HZ)
What makes you think this is needed? The code compiles fine as is...
#include <common.h> +#include <config.h> #include <clps7111.h>
And actually this _IS_ redundand, since "include/common.h" already includes <config.h>.
It's normally good coding practise to include the files which have the stuff you actually need, instead of relying on other include files including other includefiles and wondering why things break if somebody changes something in the other file. But the decision is surely up to you.
Robert
--
Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
Handelsregister: Amtsgericht Hildesheim, HRA 2686
Hornemannstraße 12, 31137 Hildesheim, Germany
Phone: +49-5121-28619-0 | Fax: +49-5121-28619-4