Re: [U-Boot] [PATCH v3 10/11] spi: cadence_qspi: Change readdata_capture() arg to bool

On Mon, Dec 5, 2016 at 11:07 AM, Phil Edworthy phil.edworthy@renesas.com wrote:

Hi Jagan,

On 02 December 2016 14:20, Jagan Teki wrote:

...

On Tue, Nov 29, 2016 at 6:28 PM, Phil Edworthy phil.edworthy@renesas.com wrote:

...

This is in preparation for adding another arg.

?? proper reason for changing arg to bool.

Purely because the patch 11 adds another arg that is a bool (which is the natural type as it is read from a dtb). Then having this bypass arg as something other than a bool look a bit odd.

Can't we make this as 11 and saying the reason for bool which is used/compatible with previous dt patch (I mean 11th patch in the current case)?

thanks!