-----Original Message----- From: york sun Sent: Wednesday, March 29, 2017 9:15 PM To: Sumit Garg sumit.garg@nxp.com; u-boot@lists.denx.de Cc: Ruchika Gupta ruchika.gupta@nxp.com; Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Mingkai Hu mingkai.hu@nxp.com; Vini Pillai vinitha.pillai@nxp.com Subject: Re: [PATCH v4] ls1046ardb: SPL size reduction in case of non-xip boot
On 03/29/2017 08:36 AM, Sumit Garg wrote:
<snip>
diff --git a/include/configs/ls1046ardb.h b/include/configs/ls1046ardb.h index 2141b82..c01eb1f 100644 --- a/include/configs/ls1046ardb.h +++ b/include/configs/ls1046ardb.h @@ -9,6 +9,18 @@
#include "ls1046a_common.h"
+/* SPL build */ +#ifdef CONFIG_SPL_BUILD +#define SPL_NO_FMAN +#define SPL_NO_QSPI +#define SPL_NO_USB +#define SPL_NO_SATA +#define SPL_NO_ENV +#endif +#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT))
#define
+SPL_NO_IFC #endif
Are these RDB specific? Why not put this block into the common header?
York
Yes these macros are used to mask macros in RDB header file from inclusion
during SPL build. Also this block can be put in common header but I am not sure how many of above macros relevant for the QDS header file.
Don't both boards have FMAN, QSPI, USB, SATA, ENV?
I had a look at QDS header file, it does have all these macros. I will move these macros to common header file in v5.
Sumit
Please be aware, I have asked Mingkai to separate DPAA_FMAN from general NET. I want to see the flexibility to use either PCIe network, and/or DPAA network separately.
York