On 01/31/2012 02:31 AM, Jason Hui wrote:
Eric,
On Tue, Jan 31, 2012 at 3:52 AM, Eric Nelson eric.nelson@boundarydevices.com wrote:
Signed-off-by: Eric Nelsoneric.nelson@boundarydevices.com Acked-by: Dirk Behmedirk.behme@de.bosch.com Acked-by: Stefano Babicsbabic@denx.de
board/freescale/mx6qsabrelite/imximage.cfg | 2 +- board/freescale/mx6qsabrelite/mx6qsabrelite.c | 25 +++++++++++++++++++++++++ include/configs/mx6qsabrelite.h | 9 +++++++++ 3 files changed, 35 insertions(+), 1 deletions(-)
After apply the patch, I have the build errors: ../mx6qsabrelite/mx6qsabrelite.c:211: undefined reference to `IMX_GPIO_NR'
So, the patch should depends on others. If one patch set is depend on others, it's better to tell it in the cover letter of your patch set. Thanks.
Ouch! It's all about the GPIO numbers...
This occurred when I re-based to Stefano's tree and will require another patch to keep the BANK:OFFSET numbering scheme. There's a patch lingering in Dirk's tree that defines IMX_GPIO_NR() in gpio.h.
See http://lists.denx.de/pipermail/u-boot/2012-January/116866.html for details.
I was hoping to get some feedback before generating a patch and revising this patch (and removing GPIO_3_19 macro):
http://lists.denx.de/pipermail/u-boot/2012-January/116874.html
That said, I'll revise and re-send along with a patch adding support for: GPIO_NUMBER(port,index) GPIO_PORT(number) GPIO_INDEX(number)