Dear Heiko Schocher,
In message 4C4441D1.7080802@denx.de you wrote:
since commit 1384f3bb8a4f9066805b70c1418eda78ecb73fdd ethernet names with spaces drop a
Warning: eth device name has a space!
message. This patch fix it for "FEC ETHERNET" devices found on mpc512x, mpc5xxx, mpc8xx and mpc8220 boards.
Thanks, but ...
arch/powerpc/cpu/mpc8220/fec.c | 2 +- arch/powerpc/cpu/mpc8xx/fec.c | 4 ++-- board/motionpro/motionpro.c | 4 ++-- board/stx/stxxtc/stxxtc.c | 6 +++--- board/tqc/tqm8xx/tqm8xx.c | 4 ++-- drivers/net/mpc512x_fec.c | 2 +- drivers/net/mpc5xxx_fec.c | 2 +- include/configs/NSCU.h | 1 - include/configs/TK885D.h | 6 +++--- include/configs/idmr.h | 2 +- include/configs/v38b.h | 2 +- 11 files changed, 17 insertions(+), 18 deletions(-)
...
I think we should update the occurence of this string in the documentation as well, i. e. also update the README.
While doing this, we should then fix the similar "SCC ETHERNET" as well; potentially affected files:
README arch/powerpc/cpu/mpc8260/ether_scc.c arch/powerpc/cpu/mpc8xx/scc.c board/LEOX/elpt860/README.LEOX board/RPXlite_dw/README doc/README.PlanetCore include/configs/TQM855L.h include/configs/TQM855M.h include/configs/TQM860L.h include/configs/TQM860M.h include/configs/TQM862L.h include/configs/TQM862M.h include/configs/TQM866M.h include/configs/TQM885D.h include/configs/keymile-common.h include/configs/km8xx.h
Add ditto for "FCC* ETHERNET"; potentially affected files:
arch/powerpc/cpu/mpc8260/ether_fcc.c arch/powerpc/cpu/mpc85xx/ether_fcc.c
diff --git a/arch/powerpc/cpu/mpc8220/fec.c b/arch/powerpc/cpu/mpc8220/fec.c index 5df9735..cf0ce4a 100644 --- a/arch/powerpc/cpu/mpc8220/fec.c +++ b/arch/powerpc/cpu/mpc8220/fec.c @@ -840,7 +840,7 @@ int mpc8220_fec_initialize (bd_t * bis) dev->send = mpc8220_fec_send; dev->recv = mpc8220_fec_recv;
- sprintf (dev->name, "FEC ETHERNET");
- sprintf (dev->name, "FEC_ETHERNET"); eth_register (dev);
I always wondered why we need such a long (and slow to type) name. I suggest we use this opportunity and change the name into a plain and simple "FEC" resp. "SCC" and "FCC" ?
Best regards,
Wolfgang Denk