Dear Seunghyeon Rhee,
In message 4B17094D.2090300@lpmtec.com you wrote:
Dear Seunghyeon Rhee,
2009/11/28 "Seunghyeon Rhee" seunghyeon@lpmtec.com:
The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit
...
Please rebase this patch. s3c6400.h is moved to include/asm-arm/arch-s3c64xx/s3c6400.h
Thanks Minkyu Kang
The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit memory bus and there is no need to control CKE for each chip separately. AFAIK, CKE1 is not at all connected. Only CKE0 is used. Futhermore, it should be '0' always for S3C6410. When tested with a board which has a S3C6410 and the same memory configuration, a side effect is observed that u-boot command "reset" doesn't work leading to system hang. Leaving the bit clear is safe in most cases.
Signed-off-by: Seunghyeon Rhee seunghyeon@lpmtec.com
include/asm-arm/arch-s3c64xx/s3c6400.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Is this a patch re-submission or what? If yes, then please:
1) add a version to the subject (like "[PATCH v2]" 2) add a description of what has been changed below (!) the "---" line 3) and make sure thsat the commit message can be used - the one above is definitely unusable.
Best regards,
Wolfgang Denk