Re: [U-Boot] [PATCH 8/8] nhk8815: added lcd support

Dear Alessandro Rubini,

In message <109a8c9f77c98641a8a02c4346cd2c7d2cc6794f.1255086085.git.rubini@ unipv.it> you wrote:

From: Alessandro Rubini rubini@unipv.it

...

+void lcd_enable(void) +{

• printf("%s:%s\n", __FILE__, __func__);
• int i;

Please no declarations in the middle of code.

And probably this should be debug() instead of printf() ?

+int nhk8815_backlight_on(void) +{

• printf("%s:%s\n", __FILE__, __func__);
• int i;

Ditto, 2x.

diff --git a/board/st/nhk8815/nhk8815.c b/board/st/nhk8815/nhk8815.c index efeb0d2..ded7681 100644 --- a/board/st/nhk8815/nhk8815.c +++ b/board/st/nhk8815/nhk8815.c @@ -107,6 +107,7 @@ int board_eth_init(bd_t *bis) #endif

extern int nhk8815_keypad_init(void); /* ./keypad.c */ +extern int nhk8815_backlight_on(void); /* in ./lcd.c */

Please move prototype decl;arations to some header file.

Best regards,

Wolfgang Denk