On 04/28/2013 01:17:34 AM, Haijun.Zhang wrote:
From: "Haijun.Zhang" haijun.zhang@freescale.com
Add platform support for p1020rdb-pd
Explain what is different about "-pd" and why this new revision requires a separate compile-time target.
If it's due to raw DDR config, say so in the changelog. Is there any way we could read a revision register to select the proper DDR config at runtime?
If it's due to different NAND page size, that will no longer be an issue once this is applied: http://patchwork.ozlabs.org/patch/223436/
+#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD)) #if defined(CONFIG_P1020RDB) #define CONFIG_BOARDNAME "P1020RDB-PC" +#elif defined(CONFIG_P1020RDB_PD) +#define CONFIG_BOARDNAME "P1020RDB-PD" +#endif
CONFIG_P1020RDB is not a good name to mean specifically the -PC revision. Change it so that CONFIG_P1020RDB is set for all revisions of P1020RDB, and introduce CONFIG_P1020RDB-PC for PC-specific things.
-Scott