Dear Fabio Estevam,
In message 1302491295-11222-1-git-send-email-festevam@gmail.com you wrote:
Use the same method of the Linux kernel to print the MX31 silicon version on boot.
Tested on a MX31PDK with a 2.0 silicon, where it shows:
CPU: Freescale i.MX31 at 531 MHz
...
+#define IMX_CHIP_REVISION_1_0 0x10 +#define IMX_CHIP_REVISION_1_1 0x11 +#define IMX_CHIP_REVISION_1_2 0x12 +#define IMX_CHIP_REVISION_1_3 0x13 +#define IMX_CHIP_REVISION_2_0 0x20 +#define IMX_CHIP_REVISION_2_1 0x21 +#define IMX_CHIP_REVISION_2_2 0x22 +#define IMX_CHIP_REVISION_2_3 0x23 +#define IMX_CHIP_REVISION_3_0 0x30 +#define IMX_CHIP_REVISION_3_1 0x31 +#define IMX_CHIP_REVISION_3_2 0x32 +#define IMX_CHIP_REVISION_3_3 0x33
What a nightmare. Does this not give the creeps to any of you who add to this code?
I'm finally fed up with this, and say NAK here.
Please use something like this instead:
#define IMX_CHIP_REVISION(maj, min) ((maj) * 16 + (min))
Feel free to add appropriate range checking on the parameters, probably using BUILD_BUG_ON() so it gets caught at compile time.
Best regards,
Wolfgang Denk